Skip to content

Comments

feat: add openAiOmitToolChoice setting for Azure/LiteLLM compatibility#10704

Closed
roomote[bot] wants to merge 1 commit intomainfrom
feature/openai-omit-tool-choice-10701
Closed

feat: add openAiOmitToolChoice setting for Azure/LiteLLM compatibility#10704
roomote[bot] wants to merge 1 commit intomainfrom
feature/openai-omit-tool-choice-10701

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 13, 2026 •
edited by ellipsis-dev bot
Loading

Related GitHub Issue

Closes: #10701

Roo Code Task Context (Optional)

N/A

Description

This PR attempts to address Issue #10701. Feedback and guidance are welcome.

Problem: Azure-hosted models (like GPT-5) accessed through LiteLLM proxies do not support the tool_choice parameter, causing 400 errors.

Solution: Added a new boolean setting openAiOmitToolChoice that allows users to optionally omit the tool_choice parameter from API requests.

Changes:

  1. Added openAiOmitToolChoice: z.boolean().optional() to the openAiSchema in packages/types/src/provider-settings.ts
  2. Modified src/api/providers/openai.ts to check for this.options.openAiOmitToolChoice before including tool_choice in requests (4 locations)
  3. Added checkbox UI in webview-ui/src/components/settings/providers/OpenAICompatible.tsx for users to enable this setting
  4. Added English translations for the new setting labels

Key implementation details:

  • Backward compatible: default behavior unchanged (tool_choice is included unless explicitly disabled)
  • Works for any Azure/LiteLLM configuration that does not support tool_choice

Test Procedure

  1. All existing OpenAI provider tests pass (48 tests)
  2. TypeScript compilation passes without errors
  3. Lint checks pass
  4. Manual testing: Enable the checkbox when using Azure-hosted models via OpenAI Compatible provider to prevent 400 errors related to tool_choice

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A - Settings checkbox UI follows existing patterns in the codebase.

Documentation Updates

  • No documentation updates are required.

Additional Notes

The setting is added in the OpenAI Compatible provider settings, near the "Use Azure" checkbox, as it is related to Azure compatibility issues.

Get in Touch

N/A - Automated PR by Roomote

Important

Adds openAiOmitToolChoice setting to optionally omit tool_choice parameter for Azure/LiteLLM compatibility, with UI and API updates.

  • Behavior:
    • Adds openAiOmitToolChoice boolean setting to openAiSchema in provider-settings.ts to optionally omit tool_choice parameter.
    • Updates OpenAiHandler in openai.ts to check openAiOmitToolChoice before including tool_choice in API requests (4 locations).
    • Adds checkbox in OpenAICompatible.tsx for users to enable/disable this setting.
  • UI:
    • Adds English translations for new setting labels in settings.json.
  • Compatibility:
    • Default behavior unchanged; tool_choice included unless openAiOmitToolChoice is enabled.
    • Supports Azure/LiteLLM configurations that do not support tool_choice.

This description was created by Ellipsis for 1b56f5e. You can customize this summary. It will automatically update as commits are pushed.

@roomote
feat: add openAiOmitToolChoice setting for Azure/LiteLLM compatibility
1b56f5e 
Add a new boolean setting that allows users to omit the tool_choice
parameter from OpenAI API requests. This fixes compatibility issues
with Azure-hosted models and LiteLLM proxies that do not support
the tool_choice parameter.

Fixes #10701
@roomote roomote bot mentioned this pull request Jan 13, 2026
Closed
@roomote
Copy link
Contributor Author

roomote bot commented Jan 13, 2026 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The implementation correctly adds the openAiOmitToolChoice setting to allow users to omit the tool_choice parameter for Azure/LiteLLM compatibility. The changes are well-structured, backward compatible, and follow existing codebase patterns.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@statichawk
Copy link

statichawk commented Jan 14, 2026

@mrubens @cte @jr This is currently a breaking issue for our org. Any thoughts would be welcome!

@daniel-lxs
Copy link
Member

daniel-lxs commented Jan 14, 2026

Hey @statichawk It sounds like your provider and model combo are not compatible with native function calling, since we are deprecating our legacy tool calling which was based on XML parsing Roo Code might become incompatible with your provider.

Can you test this workaround mentioned on the issue opened on the LiteLLM project?
BerriAI/litellm#14704 (comment)

@statichawk
Copy link

statichawk commented Jan 14, 2026

Hey @statichawk It sounds like your provider and model combo are not compatible with native function calling, since we are deprecating our legacy tool calling which was based on XML parsing Roo Code might become incompatible with your provider.

Can you test this workaround mentioned on the issue opened on the LiteLLM project? BerriAI/litellm#14704 (comment)

Thank you for a quick response. Would this be on the RooCode extension side, or our LLM provider side?

@GeekZed
Copy link

GeekZed commented Feb 3, 2026

OpenAI Compatible also need this seeting !!! pls add it . thanks!

@mrubens mrubens closed this Feb 4, 2026
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens Awaiting requested review from mrubens mrubens will be requested when the pull request is marked ready for review mrubens is a code owner

@cte cte Awaiting requested review from cte cte will be requested when the pull request is marked ready for review cte is a code owner

@jr jr Awaiting requested review from jr jr will be requested when the pull request is marked ready for review jr is a code owner

@hannesrudolph hannesrudolph Awaiting requested review from hannesrudolph hannesrudolph will be requested when the pull request is marked ready for review hannesrudolph is a code owner

@daniel-lxs daniel-lxs Awaiting requested review from daniel-lxs daniel-lxs will be requested when the pull request is marked ready for review daniel-lxs is a code owner

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Roo Code Roadmap
Status: Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] azure does not support parameters: ['tool_choice']

5 participants

@statichawk @daniel-lxs @GeekZed @mrubens @roomote